8000 Fix test that only runs in 2.7 or higher by headius · Pull Request #33 · ruby/cgi · GitHub
[go: up one dir, main page]
Skip to content

Fix test that only runs in 2.7 or higher #33

New issue < 8000 div class="d-flex flex-column p-4">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fix test that only runs in 2.7 or higher #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6066b8c
Ruby 2.7 backport about IRB (#2990)
aycabta Mar 30, 2020
ad079c1
merge some parts of CGI 0.1.1
unak Nov 24, 2021
5f569ec
Check cookie name/path/domain characters
nobu Aug 16, 2022
85e22c3
Prevent CRLF injection
mame Nov 22, 2022
107a0c6
Relax domain label restrictions
nobu Nov 22, 2022
a390f83
Bump up 0.1.0.2
hsbt Nov 22, 2022
9cab3c5
Fix test that only runs on 2.7
headius Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge some parts of CGI 0.1.1 
	Fix integer overflow

	Make use of the check in rb_alloc_tmp_buffer2.

	When parsing cookies, only decode the values

	Bump version
  • Loading branch information
@unak @hsbt
unak authored and hsbt committed Nov 21, 2022
commit ad079c1cb5f58eba1ffac46da79995fcf94a3a6e
3 changes: 2 additions & 1 deletion ext/cgi/escape/escape.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ static VALUE
optimized_escape_html(VALUE str)
{
VALUE vbuf;
char *buf = ALLOCV_N(char, vbuf, RSTRING_LEN(str) * HTML_ESCAPE_MAX_LEN);
typedef char escape_buf[HTML_ESCAPE_MAX_LEN];
char *buf = *ALLOCV_N(escape_buf, vbuf, RSTRING_LEN(str));
const char *cstr = RSTRING_PTR(str);
const char *end = cstr + RSTRING_LEN(str);

Expand Down
1 change: 0 additions & 1 deletion lib/cgi/cookie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ def self.parse(raw_cookie)
raw_cookie.split(/;\s?/).each do |pairs|
name, values = pairs.split('=',2)
next unless name and values
name = CGI.unescape(name)
values ||= ""
values = values.split('&').collect{|v| CGI.unescape(v,@@accept_charset) }
if cookies.has_key?(name)
Expand Down
2 changes: 1 addition & 1 deletion lib/cgi/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
class CGI
VERSION = "0.1.0"
VERSION = "0.1.0.1"
end
5 changes: 5 additions & 0 deletions test/cgi/test_cgi_cookie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@ def test_cgi_cookie_parse
end
end

def test_cgi_cookie_parse_not_decode_name
cookie_str = "%66oo=baz;foo=bar"
cookies = CGI::Cookie.parse(cookie_str)
assert_equal({"%66oo" => ["baz"], "foo" => ["bar"]}, cookies)
end

def test_cgi_cookie_arrayinterface
cookie = CGI::Cookie.new('name1', 'a', 'b', 'c')
Expand Down
0