8000 Fix spec NoMethodError message for .allocator on truffle Ruby by mrzasa · Pull Request #313 · ruby/bigdecimal · GitHub
[go: up one dir, main page]
Skip to content

Fix spec NoMethodError message for .allocator on truffle Ruby #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Fix spec NoMethodError message for .allocator on truffle Ruby #313

merged 1 commit into from
May 12, 2025

Conversation

mrzasa
Copy link
Contributor
@mrzasa mrzasa commented Feb 4, 2025

I've noticed test failures on truffleruby-head: https://github.com/ruby/bigdecimal/actions/runs/13139256664/job/36662137135?pr=312

 Failure: test_s_allocate(TestBigDecimal):
  Expected Exception(NoMethodError) was raised, but the message doesn't match.
  Expected /undefined.+allocate.+for BigDecimal/ to match "undefined method `__allocate__' for class BigDecimal".
  <nil> is not true.
/home/runner/.rubies/truffleruby-head/lib/gems/gems/test-unit-ruby-core-1.0.6/lib/core_assertions.rb:540:in `assert'
/home/runner/.rubies/truffleruby-head/lib/gems/gems/test-unit-ruby-core-1.0.6/lib/core_assertions.rb:511:in `assert_raise_with_message'
/home/runner/work/bigdecimal/bigdecimal/test/bigdecimal/test_bigdecimal.rb:300:in `test_s_allocate'
/home/runner/.rubies/truffleruby-head/lib/gems/gems/test-unit-3.6.7/lib/test/unit/ui/console/testrunner.rb:324: warning: too many arguments for format string
     297: 
     298:   def test_s_allocate
     299:     if RUBY_ENGINE == "truffleruby"
  => 300:       assert_raise_with_message(NoMethodError, /undefined.+allocate.+for BigDecimal/) { BigDecimal.allocate }
     301:     else
     302:       assert_raise_with_message(TypeError, /allocator undefined for BigDecimal/) { BigDecimal.allocate }
     303:     end

I believe we can safely relax the expectation without losing anything and the test will pass on truffle.

@mrzasa mrzasa marked this pull request as ready for review February 4, 2025 22:00
This was referenced Feb 4, 2025
Open
Merged
@hsbt hsbt merged commit 344b65f into ruby:master May 12, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrzasa @hsbt
0