8000 Initial impl with wontache by rtfpessoa · Pull Request #446 · rtfpessoa/diff2html · GitHub
[go: up one dir, main page]
Skip to content
/ diff2html Public

Initial impl with wontache #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initial impl with wontache #446

wants to merge 1 commit into from

Conversation

rtfpessoa
Copy link
Owner

No description provided.

@rtfpessoa rtfpessoa marked this pull request as ready for review September 14, 2022 13:04
@rtfpessoa rtfpessoa force-pushed the use-wontache branch 2 times, most recently from 23c6913 to 0319458 Compare September 14, 2022 13:12
@Lordfirespeed
Copy link
Lordfirespeed commented Mar 4, 2023 •
edited
Loading

Any updates on this PR?
I'm put off using diff2html since hogan.js is so outdated.
Happy to contribute if that would be helpful!

@rtfpessoa
Copy link
Owner Author
rtfpessoa commented Mar 4, 2023 •
edited
Loading

Any updates on this PR?

Not yet.

I'm put off using diff2html since hogan.js is so outdated.

Not sure I understand what is the problem. hogan.js is very stable and no bugs or problems were found.
We don't have any special lock on it, we are using mustache and hogan is just the best way I found at the time to render it.

Happy to contribute if that would be helpful!

wontache was pretty early at the time I started this. With the new changes it would require some bigger rewrite and I did not have time. If you want to contribute the migration go ahead and feel free to send a PR.

But TBH wontache has no releases since last October and has no version 1.x. I am ok in releasing some parallel versions but since it is not even stable and has no active development I do not feel comfortable in putting it in master.

@geevade
Copy link
geevade commented Apr 11, 2023

We were also looking forward to using diff2html, but then realized, that hogan uses some sort of eval. This conflicts with our csp -> 'call to Function() blocked by CSP' makeTemplate...

Hogan has an unfixed ticket from 10 years ago: twitter/hogan.js#135
their 'solution' didn't work:

'EvalError: Refused to evaluate a string as Javascript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self'"
at new Function()
at Hogan.makeTemplate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtfpessoa @Lordfirespeed @geevade
0