8000 A techreport.tex improvements by sainaen · Pull Request #14 · rssh/scala-gopher · GitHub
[go: up one dir, main page]

Skip to content

A techreport.tex improvements #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2016
Merged

A techreport.tex improvements #14

merged 4 commits into from
Oct 30, 2016

Conversation

sainaen
Copy link
Contributor
@sainaen sainaen commented Oct 30, 2016

HI

Let me suggest some improvements to the tech report you're writing. Please note that I'm not a native speaker so it's just a proposal that also needs a good review. :)

I've made four relatively unrelated commits, so you can choose to merge only ones that you feel ok about (most typos fixed in the first, so you'll probably want to merge at least that one).

Now, there are things that I didn't know how to fix:

  • it looks like an ending is missing for the sentence “… we can bind handling of ignored value to type by providing
    appropriative implicit conversion or use special syntax for functions which
    needs”
  • a part of the sentence “… from another
    side, it unlikely handle errors there, because we must allow a developer to
    implement own error processing”
    is broken, but unfortunately I couldn't understand what are you trying to say here

Also I didn't touch a bunch of places where I wasn't confident enough to propose corrections (for example missing/redundant articles, commas and punctuation in general, etc.)

@rssh rssh merged commit 35d94e9 into rssh:master Oct 30, 2016
@rssh
Copy link
Owner
rssh commented Oct 30, 2016

Thanks !

@sainaen sainaen deleted the techreport_rev branch October 30, 2016 22:42
@sainaen
Copy link
Contributor Author
sainaen c 7266 ommented Oct 30, 2016

No problem. Thanks for sharing your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0