8000 extract java, google java format and jmh to separate script plugins by qweek · Pull Request #401 · rsocket/rsocket-java · GitHub
[go: up one dir, main page]
Skip to content

extract java, google java format and jmh to separate script plugins #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

extract java, google java format and jmh to separate script plugins #401

wants to merge 1 commit into from

Conversation

qweek
Copy link
Contributor
@qweek qweek commented Oct 2, 2017 •
edited
Loading

configuration:

  • explicitly set gradle version and distribution type (upgrade later)

versions:

  • move dependency versions to separate file

java:

  • set encoding to UTF-8
  • disable specific compiler warnings (fix later)

codestyle:

  • set google java format version for plugin (upgrade later)
  • run formatting before compilation

benchmark:

  • exclude test dependencies from jmh jar
  • fix duplicate jmh generated classes (jmh-generated-classes, jmh-generated-sources)
  • fix broken jmh metadata files (BenchmarkList, CompilerHints)
  • fix jmh command line jar (inline dependencies with shadow plugin)
  • fix jmh task for root scope (stop generate dummy jar)
  • cleanup redundant out directory generated by IDEA
  • remove slf4j and log4j dependencies (replace with slf4j-nop logger)
  • add visual jmh report

@qweek
extract java, google java format and jmh to separate script plugins
f8f8657 
configuration:
  explicitly set gradle version and distribution type (upgrade later)
versions:
  move dependency versions to separate file
java:
  set encoding to UTF-8
  disable specific compiler warnings (fix later)
codestyle:
  set google java format version for plugin (upgrade later)
  run formatting before compilation
benchmark:
  exclude test dependencies from jmh jar
  fix duplicate jmh generated classes (jmh-generated-classes, jmh-generated-sources)
  fix broken jmh metadata files (BenchmarkList, CompilerHints)
  fix jmh command line jar (inline dependencies with shadow plugin)
  fix jmh task for root scope (stop generate dummy jar)
  cleanup redundant out directory generated by IDEA
  remove slf4j and log4j dependencies (replace with slf4j-nop logger)
  add visual jmh report
@qweek
Copy link
Contributor Author
qweek commented Oct 2, 2017 •
edited
Loading

Feel free to suggest a better name for script plugins

cli example:
java -jar build/libs/rsocket-core-0.9-SNAPSHOT-jmh.jar io.rsocket.RSocketPerf.fireAndForgetHello -t 2

known issues:

  • Exception while trying to acquire the JMH lock on Windows (C:\Windows/jmh.lock)

workaround:

  • Run IDE as administrator

@qweek
Copy link
Contributor Author
qweek commented Oct 2, 2017 •
edited
Loading

I see your pull request #397 (inline versions)
Do you have any concerns with the previous solution?
Let me know if you need help solving this problem

@yschimke
Copy link
Member
yschimke commented Oct 3, 2017

cc @robertroeser

I'll defer to Robert here. I got the gradle scripts working for snapshots and releases, but apart from that, I'm not very fussed about the structure if it's working.

@qweek qweek mentioned this pull request Oct 3, 2017
Closed
@robertroeser
Copy link
Member

I'd prefer to leave it in one file. It works now, and it's easy to find what we're doing. I don't want to dig through a bunch of different files to figure out what the version of something is, or what configuration we're using.

@qweek
Copy link
Contributor Author
qweek commented Oct 5, 2017

If you wish I can merge this changes to main build.gradle file

@qweek qweek mentioned this pull request Oct 5, 2017
Merged
@qweek qweek deleted the feature/extract-script-plugins-from-build branch October 5, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qweek @yschimke @robertroeser
0