10000 add git attributes by qweek · Pull Request #390 · rsocket/rsocket-java · GitHub
[go: up one dir, main page]

Skip to content

add git attributes #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2017
Merged

Conversation

qweek
Copy link
Contributor
@qweek qweek commented Sep 15, 2017

add .gitattributes for normalize line ending

add .gitattributes for normalize line ending
@yschimke
Copy link
Member

I'm not sold on this, whether it it worthwhile adding or default for java files should be "lf" anyway.

Happy to hear from others, particularly any windows devs. Are you on Windows?

@qweek
Copy link
Contributor Author
qweek commented Sep 15, 2017

This is the recommended setting on Windows because it ensures that your repository can be used on other platforms mind-the-end-of-your-line

tell git to detect all text files and automatically normalize them (convert CRLF to LF)

@yschimke
Copy link
Member

Can you give an example of other popular gradle java projects that apply this?

@qweek
Copy link
Contributor Author
qweek commented Sep 16, 2017

@yschimke yschimke merged commit 5d40029 into rsocket:1.0.x Sep 17, 2017
@qweek qweek deleted the feature/add-git-attributes branch September 17, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0