rsocket · yschimke · Aug 18, 2017 · Aug 18, 2017
diff --git a/rsocket-tck-drivers/src/main/java/io/rsocket/tckdrivers/common/ParseMarble.java b/rsocket-tck-drivers/src/main/java/io/rsocket/tckdrivers/common/ParseMarble.java
@@ -95,7 +95,7 @@ public ParseMarble(Subscriber<? super Payload> s, String agent) {
    * be sent. In other words, it allows onNext and onComplete to be sent even if we've sent all the
    * values we've been requested of.
    *
-   * @param m
+   * @param m marble string
    */
   public synchronized void add(String m) {
     consoleUtils.info("adding " + m);
@@ -110,7 +110,7 @@ public synchronized void add(String m) {
    * this method unblocks the sendLatch as well as the parseLatch if we have more requests, as it
    * allows both emitted and non-emitted symbols to be sent,
    *
-   * @param n
+   * @param n credits to add
    */
   public synchronized void request(long n) {
     numRequested += n;

diff --git a/rsocket-transport-aeron/src/main/java/io/rsocket/aeron/internal/EventLoop.java b/rsocket-transport-aeron/src/main/java/io/rsocket/aeron/internal/EventLoop.java
@@ -23,7 +23,8 @@ public interface EventLoop {
    * Executes an IntSupplier that returns a number greater than 0 if it wants the the event loop to
    * keep processing items, and zero its okay for the eventloop to execute an idle strategy
    *
-   * @param r
+   * @param r signal for roughly how many items could be processed.
+   * @return whether items could be processed
    */
   boolean execute(IntSupplier r);
 }
diff --git a/...transport-aeron/src/main/java/io/rsocket/aeron/internal/reactivestreams/AeronChannel.java b/...transport-aeron/src/main/java/io/rsocket/aeron/internal/reactivestreams/AeronChannel.java
@@ -56,8 +56,8 @@ public AeronChannel(
   /**
    * Subscribes to a stream of DirectBuffers and sends the to an Aeron Publisher
    *
-   * @param in
-   * @return
+   * @param in the publisher of buffers.
+   * @return Mono the completes when all publishers have been sent.
    */
   public Mono<Void> send(Flux<? extends DirectBuffer> in) {
     AeronInSubscriber inSubscriber = new AeronInSubscriber(name, destination);

diff --git a/.../src/main/java/io/rsocket/aeron/internal/reactivestreams/AeronClientChannelConnector.java b/.../src/main/java/io/rsocket/aeron/internal/reactivestreams/AeronClientChannelConnector.java
@@ -303,6 +303,9 @@ private AeronClientConfig(
      *
      * @param receiveSocketAddress the address the channels receives data on
      * @param sendSocketAddress the address the channel sends data too
+     * @param receiveStreamId receiving stream id
+     * @param sendStreamId the sending stream id
+     * @param eventLoop event loop for this client
      * @return new {@code AeronClientConfig}
      */
     public static AeronClientConfig create(

diff --git a/...-aeron/src/main/java/io/rsocket/aeron/internal/reactivestreams/ReactiveStreamsRemote.java b/...-aeron/src/main/java/io/rsocket/aeron/internal/reactivestreams/ReactiveStreamsRemote.java
@@ -81,6 +81,9 @@ interface StartedServer extends Closeable {
      * Blocks till this server shutsdown till the passed duration.
      *
      * <p><em>This does not shutdown the server.</em>
+         *
+     * @param duration the number of durationUnit to wait
+     * @param durationUnit the unit e.g. seconds
      */
     void awaitShutdown(long duration, TimeUnit durationUnit);
 

diff --git a/rsocket-transport-local/src/main/java/io/rsocket/transport/local/LocalServerTransport.java b/rsocket-transport-local/src/main/java/io/rsocket/transport/local/LocalServerTransport.java
@@ -70,6 +70,8 @@ public static LocalServerTransport createEphemeral() {
 
   /**
    * Remove an instance from the JVM registry.
+   *
+   * @param name the local transport instance to free.
    */
   public static void dispose(String name) {
     registry.remove(name);