8000 use gitcreds for managing github PAT by Aariq · Pull Request #96 · ropensci/gistr · GitHub
[go: up one dir, main page]
Skip to content

use gitcreds for managing github PAT #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

use gitcreds for managing github PAT #96

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fe62328
use gitcreds for managing github PAT
Aariq Oct 26, 2024
e0ce731
add some tests for auth
Aariq Oct 28, 2024
6111dfb
re-organize if-else statements
Aariq Oct 28, 2024
986d28b
update roxygen2 and document, fixing some roxygen2 complaints
Aariq Oct 28, 2024
c69d78c
update NEWS
Aariq Oct 28, 2024
f0bf8ef
Update .github/workflows/R-CMD-check.yaml to include GIST_TOKEN to fi…
ScientificProgrammer Oct 28, 2024
ca9c281
Revert "Update .github/workflows/R-CMD-check.yaml to include GIST_TOK…
Aariq Oct 28, 2024
a685fff
give token gist permissions
Aariq Oct 28, 2024
62caffd
give minimum permissions
Aariq Oct 28, 2024
ee26685 8000
revert
Aariq Oct 28, 2024
f50c173
Revert "Revert "Update .github/workflows/R-CMD-check.yaml to include …
Aariq Oct 28, 2024
fd71d51
use token with gist scope
Aariq Oct 28, 2024
72ba060
add test for PAT
Aariq Oct 28, 2024
5bbb5fc
Change maintainer classification in the DESCRIPTION file
ScientificProgrammer Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update NEWS
  • Loading branch information
@Aariq
Aariq committed Oct 28, 2024
commit c69d78cc0b134841a84287ed7b12d42c09929d23
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
gistr in development
===============

### NEW FEATURES

* `gistr` now uses `gitcreds` to discover GitHub PATs and now recommends you store your PAT using `gitcreds::gitcreds_set()` rather than as the `GITHUB_PAT` environment variable (although this still works).

### BUG FIXES

* fix `gist_auth()`: at some point `httr::oauth2.0_token` stopped returning the token in the `headers` slot; can't figure out when this change happened; fix is to get the token from a different place in the returned object; changes to `gist_auth()` to access that new path to the token (#83)
Expand Down
Loading
0