8000 docs: improve command by code-group by thinkasany · Pull Request #5587 · rollup/rollup · GitHub
[go: up one dir, main page]
Skip to content

docs: improve command by code-group #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukastaegert merged 2 commits into from
Jul 26, 2024
Merged

docs: improve command by code-group #5587

lukastaegert merged 2 commits into from
Jul 26, 2024

Conversation

@thinkasany
Copy link
Contributor
@thinkasany thinkasany commented Jul 24, 2024

This PR contains:

  • documentation

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Make the command line cleaner and clearer by ::: code-group;

before：
image

after：
image

@vercel
Copy link
vercel bot commented Jul 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 7:25pm

lukastaegert
lukastaegert approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, looks good to me!

@lukastaegert lukastaegert enabled auto-merge July 26, 2024 19:24
@lukastaegert lukastaegert added this pull request to the merge queue Jul 26, 2024
@codecov
Copy link
codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (27260de) to head (57892f3).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5587   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         241      241           
  Lines        9273     9273           
  Branches     2444     2444           
=======================================
  Hits         9185     9185           
  Misses         58       58           
  Partials       30       30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into rollup:master with commit c16c924 Jul 26, 2024
@github-actions
Copy link
github-actions bot commented Jul 27, 2024

This PR has been released as part of rollup@4.19.1. You can test it via npm install rollup.

@YashGovekar YashGovekar mentioned this pull request Aug 17, 2024
Open
@x-way x-way mentioned this pull request Aug 18, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request Aug 19, 2024
Open
This was referenced Aug 19, 2024
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Aug 23, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Aug 24, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Aug 24, 2024
Open
This was referenced Aug 25, 2024
Open
Open
Open
@jamesleesaunders jamesleesaunders mentioned this pull request Aug 28, 2024
Closed
This was referenced Aug 28, 2024
Open
Open
Open
Open
This was referenced Sep 15, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 17, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 22, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 23, 2024
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
9ABC
Open
This was referenced Oct 4, 2024
Open
Open
@YashGovekar YashGovekar mentioned this pull request Oct 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 4, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkasany @lukastaegert
0