8000 refactor(finalisers): condition branch by Simon-He95 · Pull Request #5570 · rollup/rollup · GitHub
[go: up one dir, main page]
Skip to content

refactor(finalisers): condition branch #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukastaegert merged 4 commits into from
Jul 10, 2024
Merged

refactor(finalisers): condition branch #5570

lukastaegert merged 4 commits into from
Jul 10, 2024

Conversation

@Simon-He95
Copy link
Contributor
@Simon-He95 Simon-He95 commented Jul 9, 2024 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@vercel
Copy link
vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:20am

@codecov
Copy link
codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (21f9a49) to head (b077beb).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5570   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files         238      238           
  Lines        9252     9256    +4     
  Branches     2439     2441    +2     
=======================================
+ Hits         9164     9168    +4     
  Misses         58       58           
  Partials       30       30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Simon-He95 Simon-He95 marked this pull request as ready for review July 9, 2024 09:21
lukastaegert
lukastaegert approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert added this pull request to the merge queue Jul 10, 2024
Merged via the queue into rollup:master with commit 13cdab5 Jul 10, 2024
@Simon-He95 Simon-He95 deleted the refactor branch July 11, 2024 05:38
@github-actions
8000 Copy link
github-actions bot commented Jul 20, 2024

This PR has been released as part of rollup@4.19.0. You can test it via npm install rollup.

@YashGovekar YashGovekar mentioned this pull request Aug 10, 2024
Open
@x-way x-way mentioned this pull request Aug 10, 2024
Closed
@hashim21223445 hashim21223445 mentioned this pull request Aug 10, 2024
Merged
@leonardoadame leonardoadame mentioned this pull request Aug 10, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Aug 10, 2024
Merged
This was referenced Aug 11, 2024
Open
Open
Open
Open
Open
@x-way x-way mentioned this pull request Aug 18, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request Aug 19, 2024
Open
This was referenced Sep 15, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 17, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 19, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 22, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Sep 23, 2024
Open
This was referenced Sep 23, 2024
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
This was referenced Oct 4, 2024
Open
Open
@YashGovekar YashGovekar mentioned this pull request Oct 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 4, 2024
Open
@YashGovekar YashGovekar mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Simon-He95 @lukastaegert @zhangmo8
0