fix: conditional/logical expression should request a new tree-shaking #5481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5481 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 238 238
Lines 9554 9560 +6
Branches 2439 2444 +5
=======================================
+ Hits 9443 9449 +6
Misses 46 46
Partials 65 65 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
Apr 21, 2024
Member
There was a problem hiding this comment.
👍 Thanks for quickly looking into this!
|
This PR has been released as part of rollup@4.16.1. You can test it via |
9 tasks
This was referenced May 21, 2024
This was referenced May 23, 2024
This was referenced Jul 23, 2024
This was referenced Jul 28, 2024
This was referenced Jul 30, 2024
This was referenced Aug 2, 2024
This was referenced Aug 9, 2024
This was referenced Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
While we should not request a tree-shaking in
ConditionalExpressionorLogicalExpressionif nothing happens; we should request one if anything changes.One way to validate this fix is to use example from #5480, see repl, another one is to use index.js from https://github.com/elchininet/shadow-dom-selector