8000 Fix base classes with namespaces by virtuald · Pull Request #40 · robotpy/robotpy-cppheaderparser · GitHub
[go: up one dir, main page]
Skip to content

Fix base classes with namespaces #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fix base classes with namespaces #40

merged 1 commit into from
Mar 4, 2020

Conversation

virtuald
Copy link
Member
@virtuald virtuald commented Mar 3, 2020

@virtuald virtuald mentioned this pull request Mar 3, 2020
Closed
tpaviot
tpaviot reviewed Mar 4, 2020
View reviewed changes
Copy link
@tpaviot tpaviot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works, thanks for the quick fix

tpaviot
tpaviot approved these changes Mar 4, 2020
View reviewed changes
Copy link
@tpaviot tpaviot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virtuald virtuald merged commit dd564dd into master Mar 4, 2020
@virtuald
Copy link
Member Author
virtuald commented Mar 4, 2020

Should be on pypi as robotpy-cppheaderparser 5.0.3 in a few minutes.

@virtuald virtuald deleted the fix-39 branch March 4, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpaviot tpaviot tpaviot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in 3.3.0
2 participants
@virtuald @tpaviot
0