8000 Validate hook method · Issue #4 · rjz/githubhook · GitHub
[go: up one dir, main page]
Skip to content

Validate hook method #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rjz opened this issue Jun 7, 2016 · 1 comment
Closed

Validate hook method #4

rjz opened this issue Jun 7, 2016 · 1 comment

Comments

@rjz
Copy link
Owner
rjz commented Jun 7, 2016

Github hooks should always be submitted via an HTTP POST. To reflect this, let's check the method of incoming requests and fix tests as needed.
rjz added a commit that referenced this issue Jun 7, 2016
@rjz
Validate POST method (#4)
d4e4d5a 
Webhooks should always be submitted as POST requests

Ref: https://developer.github.com/webhooks/
rjz added a commit that referenced this issue Jun 7, 2016
@rjz
Merge pull request #5 from rjz/fix/http-request-method
9299dde 
Validate POST method (#4)
@rjz
Copy link
Owner Author
rjz commented Aug 5, 2016

This was fixed in #5. Closing.

@rjz rjz closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjz
0