8000 support the sha256 signature (as the sha1 has been deprecated) · Issue #13 · rjz/githubhook · GitHub
[go: up one dir, main page]
Skip to content

support the sha256 signature (as the sha1 has been deprecated) #13 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dolanor opened this issue Feb 24, 2023 · 1 comment
Closed

support the sha256 signature (as the sha1 has been deprecated) #13

dolanor opened this issue Feb 24, 2023 · 1 comment

Comments

@dolanor
Copy link
dolanor commented Feb 24, 2023 •
edited
Loading

Hi,
Thank you for this library. Using it lately, I discovered it still uses the default deprecated signature hash function.
It is deprecated since

Note: For backward-compatibility, we also include the x-hub-signature header that is generated using the SHA-1 hash function. If possible, we recommend that you use the x-hub-signature-256 header for improved security. The example below demonstrates using the x-hub-signature-256 header.
rjz added a commit that referenced this issue Mar 3, 2023
@rjz
Swaps in SHA256 signature (fixes #13)
4bddd07
rjz added a commit that referenced this issue Mar 3, 2023
@rjz
Swaps in SHA256 signature (fixes #13)
9a95d2a
@rjz rjz closed this as completed in cc67f35 Mar 3, 2023
rjz added a commit that referenced this issue Mar 3, 2023
@rjz
Merge pull request #15 from rjz/feature/sha256
8aaa0d6 
Swaps in SHA256 signature (fixes #13)
@rjz
Copy link
Owner
rjz commented Mar 3, 2023

Thanks, @dolanor, this should be fixed in #15.

Please reopen if you run into any issues with the updated signature!

rjz added a commit that referenced this issue Dec 26, 2023
@rjz
v0.1.0
870f367 
Changes in this release:

- Swapped in SHA256 signature (#13)
- Adopt Github action for testing
- Checked in go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjz @dolanor
0