Fixed crash due to uninitialized variable #116
Conversation
|
Looks like we might need to make this change in OTASettingsService too, _arduinoOTA is uninitialized there. |
|
Right, it is the second place. |
|
Out of interest, what steps induce the crash? |
|
Nothing special, just a piece of bad luck. It starts crashing on boot as I reformat the code. I create ESP8266React dynamically with new operator and have so called "Emergency Protocol" that works prior instancing ESP8266React. Usually when program starts all memory (heap+stack) filled with zeros. So you don't see the problem with an example code as it declares global instance of ESP8266React. It is the first object that program creates in a fresh memory. In my case ESP8266React reuses memory previously occupied by "Emergency Protocol". C++ delete operator marks a piece of memory as free but doesn't wipe it out. A a result uninitialized pointer get a random value. |
|
Your bottle project looks cool :)
I did something similar too for my christmas tree.
…On Wed, May 20, 2020 at 6:24 PM kasedy ***@***.***> wrote:
Nothing special, just a piece of bad luck.
It starts crashing on boot as I reformat the code. I create ESP8266React
dynamically with new operator and have so called "Emergency Protocol" that
works prior instancing ESP8266React.
Usually when program start all memory (heap+stack) filled with zeros. So
you don't see the problem with an example code as it declares global
instance of ESP8266React. It is the first object that program creates in a
fresh memory.
In my case ESP8266React reuses memory previously occupied by "Emergency
Protocol". C++ delete operator marks a piece of memory as free but doesn't
wipe it out. A a result uninitialized pointer get a random value.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKE4VCL5T4NYY2KFBQ6DFDRSQG5NANCNFSM4NFXSONQ>
.
|
Fixed crash.