[Console] fix abstract Output class that fasly claims to support guessing of decorated variable.

Tobion · Tobion · commit 9dcc9facf025 · 2013-05-14T18:18:10.000+02:00
Also we don't need to typecast to boolean as its already done by the formatter and its his responsibility
diff --git a/src/Symfony/Component/Console/Output/Output.php b/src/Symfony/Component/Console/Output/Output.php
@@ -36,16 +36,16 @@ abstract class Output implements OutputInterface
      * Constructor.
      *
      * @param integer                  $verbosity The verbosity level (self::VERBOSITY_QUIET, self::VERBOSITY_NORMAL, self::VERBOSITY_VERBOSE)
-     * @param Boolean                  $decorated Whether to decorate messages or not (null for auto-guessing)
+     * @param Boolean                  $decorated Whether to decorate messages or not
      * @param OutputFormatterInterface $formatter Output formatter instance
      *
      * @api
      */
-    public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = null, OutputFormatterInterface $formatter = null)
+    public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = false, OutputFormatterInterface $formatter = null)
     {
         $this->verbosity = null === $verbosity ? self::VERBOSITY_NORMAL : $verbosity;
         $this->formatter = null === $formatter ? new OutputFormatter() : $formatter;
-        $this->formatter->setDecorated((Boolean) $decorated);
+        $this->formatter->setDecorated($decorated);
     }
 
     /**
@@ -81,7 +81,7 @@ public function getFormatter()
      */
     public function setDecorated($decorated)
     {
-        $this->formatter->setDecorated((Boolean) $decorated);
+        $this->formatter->setDecorated($decorated);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -36,16 +36,16 @@ abstract class Output implements OutputInterface`
`36`	`36`	`* Constructor.`
`37`	`37`	`*`
`38`	`38`	`* @param integer $verbosity The verbosity level (self::VERBOSITY_QUIET, self::VERBOSITY_NORMAL, self::VERBOSITY_VERBOSE)`
`39`		`- * @param Boolean $decorated Whether to decorate messages or not (null for auto-guessing)`
	`39`	`+ * @param Boolean $decorated Whether to decorate messages or not`
`40`	`40`	`* @param OutputFormatterInterface $formatter Output formatter instance`
`41`	`41`	`*`
`42`	`42`	`* @api`
`43`	`43`	`*/`
`44`		`- public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = null, OutputFormatterInterface $formatter = null)`
	`44`	`+ public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = false, OutputFormatterInterface $formatter = null)`
`45`	`45`	`{`
`46`	`46`	`$this->verbosity = null === $verbosity ? self::VERBOSITY_NORMAL : $verbosity;`
`47`	`47`	`$this->formatter = null === $formatter ? new OutputFormatter() : $formatter;`
`48`		`- $this->formatter->setDecorated((Boolean) $decorated);`
	`48`	`+ $this->formatter->setDecorated($decorated);`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/**`
`@@ -81,7 +81,7 @@ public function getFormatter()`
`81`	`81`	`*/`
`82`	`82`	`public function setDecorated($decorated)`
`83`	`83`	`{`
`84`		`- $this->formatter->setDecorated((Boolean) $decorated);`
	`84`	`+ $this->formatter->setDecorated($decorated);`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`/**`