[Console] the default type value should use the constant in OutputInterface::write

Tobion · Tobion · commit 2628d889a7d8 · 2013-05-14T18:09:22.000+02:00
diff --git a/src/Symfony/Component/Console/Output/NullOutput.php b/src/Symfony/Component/Console/Output/NullOutput.php
@@ -78,15 +78,15 @@ public function getVerbosity()
     /**
      * {@inheritdoc}
      */
-    public function writeln($messages, $type = 0)
+    public function writeln($messages, $type = self::OUTPUT_NORMAL)
     {
         // do nothing
     }
 
     /**
      * {@inheritdoc}
      */
-    public function write($messages, $newline = false, $type = 0)
+    public function write($messages, $newline = false, $type = self::OUTPUT_NORMAL)
     {
         // do nothing
     }
diff --git a/src/Symfony/Component/Console/Output/Output.php b/src/Symfony/Component/Console/Output/Output.php
@@ -128,7 +128,7 @@ public function getVerbosity()
      *
      * @api
      */
-    public function writeln($messages, $type = 0)
+    public function writeln($messages, $type = self::OUTPUT_NORMAL)
     {
         $this->write($messages, true, $type);
     }
@@ -144,7 +144,7 @@ public function writeln($messages, $type = 0)
      *
      * @api
      */
-    public function write($messages, $newline = false, $type = 0)
+    public function write($messages, $newline = false, $type = self::OUTPUT_NORMAL)
     {
         if (self::VERBOSITY_QUIET === $this->verbosity) {
             return;
diff --git a/src/Symfony/Component/Console/Output/OutputInterface.php b/src/Symfony/Component/Console/Output/OutputInterface.php
@@ -43,7 +43,7 @@ interface OutputInterface
      *
      * @api
      */
-    public function write($messages, $newline = false, $type = 0);
+    public function write($messages, $newline = false, $type = self::OUTPUT_NORMAL);
 
     /**
      * Writes a message to the output and adds a newline at the end.
@@ -53,7 +53,7 @@ public function write($messages, $newline = false, $type = 0);
      *
      * @api
      */
-    public function writeln($messages, $type = 0);
+    public function writeln($messages, $type = self::OUTPUT_NORMAL);
 
     /**
      * Sets the verbosity of the output.

Original file line number	Diff line number	Diff line change
`@@ -78,15 +78,15 @@ public function getVerbosity()`
`78`	`78`	`/**`
`79`	`79`	`* {@inheritdoc}`
`80`	`80`	`*/`
`81`		`- public function writeln($messages, $type = 0)`
	`81`	`+ public function writeln($messages, $type = self::OUTPUT_NORMAL)`
`82`	`82`	`{`
`83`	`83`	`// do nothing`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`/**`
`87`	`87`	`* {@inheritdoc}`
`88`	`88`	`*/`
`89`		`- public function write($messages, $newline = false, $type = 0)`
	`89`	`+ public function write($messages, $newline = false, $type = self::OUTPUT_NORMAL)`
`90`	`90`	`{`
`91`	`91`	`// do nothing`
`92`	`92`	`}`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public function getVerbosity()`
`128`	`128`	`*`
`129`	`129`	`* @api`
`130`	`130`	`*/`
`131`		`- public function writeln($messages, $type = 0)`
	`131`	`+ public function writeln($messages, $type = self::OUTPUT_NORMAL)`
`132`	`132`	`{`
`133`	`133`	`$this->write($messages, true, $type);`
`134`	`134`	`}`
`@@ -144,7 +144,7 @@ public function writeln($messages, $type = 0)`
`144`	`144`	`*`
`145`	`145`	`* @api`
`146`	`146`	`*/`
`147`		`- public function write($messages, $newline = false, $type = 0)`
	`147`	`+ public function write($messages, $newline = false, $type = self::OUTPUT_NORMAL)`
`148`	`148`	`{`
`149`	`149`	`if (self::VERBOSITY_QUIET === $this->verbosity) {`
`150`	`150`	`return;`