[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added _plot_iterations() function to the NuthKaab() class. #8

Open
wants to merge 3 commits into
base: coreg_point_support
Choose a base branch
from

Conversation

mmazzolini
Copy link

Hi Romain, this week I've been working on coregistering a dem with ICESat-2 with your code modified by Désirée. She added some plotting for understanding the iterations in the NuthKaab algorithm. With precious help from Erik (who joined us this week) I made the code OO. Hope this makes sense to you, ofc we can improve this more and test it better than I did. We could also set up a meeting if you want.

This function [_plot_iterations()] plots the graph of Normalized elevation difference vs Aspect and the fitted curve for each iteration of the NuthKaab algorithm. To be able to do this, in the _meta attribute I added the following [I am not entirely convinced it's the proper place/naming]:

  • partial_offset_east_px (list)
  • partial_offset_north_px (list)
  • partial_offset_vertical (list)
  • aspect -> array with the aspect for all the points
  • differences -> list of arrays with the el. differences for all the points
  • slopes -> list of arrays with the slopes #TODO: fix the slope computation, now it computes the slope with horizontal distance in pixels.
  • these last two could be together (as normalized el. difference)
  • all the lists are as long as the n of iterations.

TODO & questions:

  • it would maybe be clever to reduce the numerosity of the lists in the _meta. for large dems it could be too much information to handle
  • modify the slope function (right now the angle represents m/pixels)

Marco Mazzolini and others added 3 commits October 6, 2022 17:10
This function plots the graph Normalized elevation difference vs Aspect and the fitted curve for each iteration.
To be able to do this, in the _meta attribute I added the following:
 - partial_offset_east_px (list)
 - partial_offset_north_px (list)
 - partial_offset_vertical (list)
 - aspect  -> array with the aspect for all the points
 - differencers -> list with array with the el. differences for all the points
 - slopes -> list with array with the slopes #TODO: fix the slope computation, now it compute the slope with horiz distance in pixels.
 * these last two could be together (as normalized el. difference)
 * all the lists are as long as the n of iterations.

committer: mmazzolini, under precious help of erikmannerfelt. the code was originally written by desireetreichler.
…account the numerosity of data into the aspect bin. ## still need to consider the number of photons per burst.

+ The _plot_iterations function can now save the figures, in the location specified with the file_name argoument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant