8000 CI: don't use `fetch-tags` in wheel build jobs · rgommers/numpy@da4d2b0 · GitHub
[go: up one dir, main page]

Skip to content

Commit da4d2b0

Browse files
committed
CI: don't use fetch-tags in wheel build jobs
This failed in combination with tag-based triggers: - issue: numpygh-25979 - cause: numpy#25981 (comment) More importantly, we don't need to fetch either the tags or the whole commit history, because: (a) we don't derive the version number from the last tag, but from parsing pyproject.toml (b) we don't use a commit count, but only yyyymmdd.git-hash See `numpy/_build_utils/gitversion.py` Done only in the wheel build job right now, because that's where the problem is and we're in a hurry to solve it on the 2.0.x branch. However, this change should be fine everywhere. [skip cirrus] [skip circle] [skip azp]
1 parent 16e9492 commit da4d2b0

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

.github/workflows/wheels.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,6 @@ jobs:
103103
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
104104
with:
105105
submodules: true
106-
# versioneer.py requires the latest tag to be reachable. Here we
107-
# fetch the complete history to get access to the tags.
108-
# A shallow clone can work when the following issue is resolved:
109-
# https://github.com/actions/checkout/issues/338
110-
fetch-tags: true
111106

112107
- name: Setup MSVC (32-bit)
113108
if: ${{ matrix.buildplat[1] == 'win32' }}
@@ -217,11 +212,6 @@ jobs:
217212
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
218213
with:
219214
submodules: true
220-
# versioneer.py requires the latest tag to be reachable. Here we
221-
# fetch the complete history to get access to the tags.
222-
# A shallow clone can work when the following issue is resolved:
223-
# https://github.com/actions/checkout/issues/338
224-
fetch-tags: true
225215
# Used to push the built wheels
226216
- uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
227217
with:

0 commit comments

Comments
 (0)
0