Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds context manager support to the Restate SDK, allowing handlers to specify async context managers that will be automatically entered/exited during handler invocation. The feature includes a contextvar utility decorator that captures yielded values in context variables for easy access within handlers.
Key changes:
- Added
contextvardecorator for async context managers that stores yielded values in context variables - Extended Service, Object, and Workflow classes to accept and combine context managers at both class and handler level
- Integrated context manager execution into the handler invocation flow using AsyncExitStack
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/restate/context_managers.py | New file implementing the contextvar decorator utility |
| python/restate/extensions.py | Exports the new contextvar decorator |
| python/restate/handler.py | Added context_managers field to Handler dataclass and make_handler function |
| python/restate/service.py | Added context_managers parameter to Service class and handler decorator with combining logic |
| python/restate/object.py | Added context_managers parameter to VirtualObject class and handler decorator with combining logic |
| python/restate/workflow.py | Added context_managers parameter to Workflow class, main, and handler decorators with combining logic |
| python/restate/server_context.py | Integrated AsyncExitStack to enter context managers during handler invocation |
| tests/ext.py | Added test demonstrating context manager usage with the contextvar decorator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.