E5F3 when retrieving queue name, check for 'queue_name' which is how ActiveJob defines queue names by josh-m-sharpe · Pull Request #1713 · resque/resque · GitHub
[go: up one dir, main page]
Skip to content

when retrieving queue name, check for 'queue_name' which is how ActiveJob defines queue names #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josh-m-sharpe wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

when retrieving queue name, check for 'queue_name' which is how ActiveJob defines queue names #1713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/resque.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,8 +502,9 @@ def dequeue(klass, *args)
# Given a class, try to extrapolate an appropriate queue based on a
# class instance variable or `queue` method.
def queue_from_class(klass)
(klass.instance_variable_defined?(:@queue) && klass.instance_variable_get(:@queue)) ||
(klass.respond_to?(:queue) and klass.queue)
klass.instance_variable_get(:@queue) ||
(klass.respond_to?(:queue) && klass.queue) ||
(klass.respond_to?(:queue_name) && klass.new.queue_name)
Copy link
Contributor
@iloveitaly iloveitaly Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add more inline documentation here about what cases these different lines are handling? Even just a link to this PR in code would be helpful.

Copy link
Contributor
@iloveitaly iloveitaly Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josh-m-sharpe quick reminder here! Would love to tidy up this PR and get it merged.

Copy link
Contributor Author
@josh-m-sharpe josh-m-sharpe Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to tidy it up and get it merged!

Copy link
Contributor
@varyonic varyonic Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, I found it useful. Has it been superseded by another solution or shall I fork/rebase and resubmit?

end

# This method will return a `Resque::Job` object or a non-true value
Expand Down
0