improve-shortcut-help - Optimize feature
#8797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Maybe we should memoize entire contents of this dialog since GitHub doesn't cache the shortcut list. Having to look at the loading spinner every time I open the dialog is killing me. What do you think? |
Member
Author
Implemented |
SunsetTechuila
commented
Nov 27, 2025
improve-shortcut-help - Optimizeimprove-shortcut-help - Speed up dialog display
Member
|
If it works, no need to spend time on it |
Member
Author
|
2a3521e is a small change. Are you not going to accept it either? |
Member
|
Your last comment said something wasn't working and was asking me for help. I don't have time to optimize things right now |
Member
Author
|
If you reopen this PR, I'll revert it back to 2a3521e, which is ready to be reviewed and merged |
improve-shortcut-help - Speed up dialog displayimprove-shortcut-help - Optimize feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the feature by:
A follow-up to #8775
Test URLs
Screenshot