-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
status-subscription - Restore feature
#8790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status-subscription - Restore feature
#8790
Conversation
|
Is there is a way to obtain pr subscription state via api? |
No, that's the issue 🥲 |
| } | ||
|
|
||
| const body = { | ||
| query: 'dd170c659a085a45885ee5a168fc52c8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that this is a generated ID and it might break on the next deployment. Let's wait a week or two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that this is a generated ID
Yes
Let's wait a week or two.
Absolutely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works - the hash hasn't changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash has changed, but the server doesn't reject requests with an outdated hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IssueViewerSecondaryViewQuery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated hash still works
I think it's a good idea to keep track of how long the server will accept the outdated hash, so I will continue to leave comments like this from time to time. Please unsubscribe if you don't want to be notified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated hash
The one currently used by the extension (fa182058c0b83a77481f98108cdbf1eb) is now outdated too - it has already changed again (86847801024939b9ae06cb1ca8a0c3dc)
Co-authored-by: fregante <me@fregante.com>
| const {id} = issue.repository.issue; | ||
|
|
||
| const body = { | ||
| query: 'd0752b2e49295017f67c84f21bfe41a3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hash seems to be quite stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateIssueSubscriptionMutation
|
YOLO |
|
Thanks for working on this! I didn't really expect this feature to ever work again. Let's hope we don't need to hotfix it |
|
Speaking of YOLO, I added you to https://github.com/refined-github/yolo so you can add to |
|
You can now create branches in this repo to open PRs. Still wait for reviews before merging 🙏 |
|
Sorry, I can't resist clicking this checkbox. No idea what it does, tho
|

I don't really expect this to be merged
Fixes #7968
Test URLs
#8785
Screenshot