8000 `pr-jump-to-first-non-viewed-file` - Disable feature on PR commit pages by SunsetTechuila · Pull Request #8778 · refined-github/refined-github · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@SunsetTechuila
Copy link
Member

fixes:

image

Test URLs

https://github.com/refined-github/refined-github/pull/8763/commits/139a39cf8dd9d6acad3c895a83134247d4ccae5a

Screenshot

@SunsetTechuila SunsetTechuila changed the title pr-jump-to-first-non-viewed-file - Don't run feature on commit pages pr-jump-to-first-non-viewed-file - Exclude PR commit pages Nov 18, 2025
@fregante fregante added the bug label Nov 18, 2025
@SunsetTechuila
Copy link
Member Author
SunsetTechuila commented Nov 19, 2025

I noticed that all the files after the eslint config, which are lazy loaded, have a "Viewed" checkbox. Could it be a GitHub bug that others don't?

image

@SunsetTechuila SunsetTechuila marked this pull request as draft November 19, 2025 01:12
@fregante
Copy link
Member

Could it be a GitHub bug

Likely. This is a minor feature anyway, I wouldn't spend too much time on figuring out these details

@SunsetTechuila SunsetTechuila marked this pull request as ready for review December 2, 2025 07:03
@SunsetTechuila SunsetTechuila changed the title pr-jump-to-first-non-viewed-file - Exclude PR commit pages pr-jump-to-first-non-viewed-file - Disable feature on PR commit pages Dec 3, 2025
@SunsetTechuila
Copy link
Member Author

Could it be a GitHub bug that others don't?

It was a bug that others did 🤷‍♂️

@SunsetTechuila
Copy link
Member Author
SunsetTechuila commented Dec 11, 2025

https://github.com/refined-github/refined-github/pull/8763/commits/139a39cf8dd9d6acad3c895a83134247d4ccae5a -> https://github.com/refined-github/refined-github/pull/8763/changes/139a39cf8dd9d6acad3c895a83134247d4ccae5a

I suppose isPRCommit should be updated to handle the new urls

@fregante
Copy link
Member

Can you send a PR for that?

@SunsetTechuila
Copy link
Member Author

Sure, I'll also create a follow-up for the features that run on PR commit pages

@fregante fregante merged commit aabfde1 into refined-github:main Dec 13, 2025
9 checks passed
@SunsetTechuila SunsetTechuila deleted the jump branch December 13, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants

0