E527 `more-file-links` - Restore on new PR & commit pages by SunsetTechuila · Pull Request #8757 · refined-github/refined-github · GitHub
[go: up one dir, main page]
Skip to content

more-file-links - Restore on new PR & commit pages #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 9 commits into from
Nov 12, 2025
Merged

more-file-links - Restore on new PR & commit pages #8757

fregante merged 9 commits into from
Nov 12, 2025

Conversation

@SunsetTechuila
Copy link
Member
@SunsetTechuila SunsetTechuila commented Nov 10, 2025 •
edited
Loading

SunsetTechuila
SunsetTechuila commented Nov 10, 2025
View reviewed changes
@fregante fregante added the bug label Nov 10, 2025
fregante
fregante approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member
@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 😍

Image

SunsetTechuila
SunsetTechuila commented Nov 10, 2025
View reviewed changes
fregante
fregante reviewed Nov 11, 2025
View reviewed changes
fregante
fregante reviewed Nov 11, 2025
View reviewed changes
fregante
fregante reviewed Nov 11, 2025
View reviewed changes
fregante
fregante reviewed Nov 11, 2025
View reviewed changes
fregante
fregante reviewed Nov 11, 2025
View reviewed changes
fregante
fregante reviewed Nov 11, 2025
View reviewed changes
@SunsetTechuila @fregante
declare getMenuItem as function
dc6b1c9 
Co-authored-by: fregante <me@fregante.com>
@fregante
Copy link
Member
fregante commented Nov 11, 2025

Is the linter even working? 🤔 Line 45 has a trailing semicolon that shouldn't be there. This is not the first time I'm seeing simple lint errors not being reported.

Also getMenuItem should be moved to the top level, I just realized

@fregante
Copy link
Member
fregante commented Nov 11, 2025

Is the linter even working? 🤔

@fregante fregante enabled auto-merge (squash) November 12, 2025 10:37
@fregante fregante merged commit 6dbed53 into refined-github:main Nov 12, 2025
8 checks passed
fregante
fregante reviewed Nov 12, 2025
View reviewed changes
@SunsetTechuila SunsetTechuila deleted the more-file-links branch November 12, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SunsetTechuila @fregante
0