actions-run-removal - New feature
#8708
Conversation
quick-delete-cancel-workflow: add new featurequick-delete-cancel-workflow - New feature
| rightControlsContainer.prepend(cancelForm); | ||
| } | ||
|
|
||
| rightControlsContainer.classList.toggle('d-flex', !!(cancelForm || deleteWorkflowButton)); |
There was a problem hiding this comment.
Given the changes suggested, you're probably going to use something like:
wrapAll(<div className="d-flex flex-column"/>, contextMenuDetails, cancelForm, deleteWorkflowButton)This way they're be wrapped if they exist. And if they don't, that's likely fine, no visual change with this extra element.
| const deleteWorkflowButton = $('button', deleteWorkflowMenuItem); | ||
| transformIntoIconButton(deleteWorkflowButton, <TrashIcon />); | ||
| deleteWorkflowButton.classList.add('rgh-delete-workflow-run'); | ||
| rightControlsContainer.prepend(deleteWorkflowMenuItem); |
There was a problem hiding this comment.
it is prepended, and not appended, so that the cloned dialog opens instead of the one inside the context menu
| } | ||
|
|
||
| if (cancelForm || deleteWorkflowMenuItem) { | ||
| rightControlsContainer.classList.add('d-flex', 'flex-column-reverse'); |
But definitely not |
|
Maybe |
quick-delete-cancel-workflow - New featurequick-workflow-run-actions - New feature
|
I think we have another workflow feature. Technically it's deleting a run, so it should include that. "quick-run-removal" or "quick-workflow-run-removal" but I prefer the 3-word version. |
We already have several features named like that
But what about cancellation? |
|
Same same Names don't have to be exact. See notes in wiki https://github.com/refined-github/refined-github/wiki/Contributing#feature-name |
quick-workflow-run-actions - New featurequick-workflow-run-removal - New feature
|
renamed |
|
quick-workflow-run-removal - New featureactions-run-removal - New feature
|
We have |
7492c52 to
5f2f473
Compare
I want to move away from "quick" since it's relatively redundant. Most features let you do things faster.
I attempted it but I agree it's better here and it matches the red shown in the dropdown. |
argh. Since when GitHub Desktop force pushes?! Didn't mean to do that |
b57e212 to
b216181
Compare
resolves #8092
Test URLs
https://github.com/refined-github/refined-github/actions
Screenshot