E529 Meta: Remove `gecko_android.id` from manifest by willdurand · Pull Request #8683 · refined-github/refined-github · GitHub
[go: up one dir, main page]
Skip to content

Meta: Remove gecko_android.id from manifest #8683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 1 commit into from
Sep 23, 2025
Merged

Meta: Remove gecko_android.id from manifest #8683

fregante merged 1 commit into from
Sep 23, 2025

Conversation

@willdurand
Copy link
Contributor
@willdurand willdurand commented Sep 22, 2025

The Firefox id property isn't accepted in bss.gecko_android.

@willdurand
Remove the add-on id in bss.gecko_android
ede038a 
The `id` property isn't accepted in `bss.gecko_android`.
@fregante
Copy link
Member
fregante commented Sep 22, 2025

What's bss.gecko_android?

@jdreesen
Copy link
jdreesen commented Sep 22, 2025

Just a guess, but... bss = browser_specific_settings?

@fregante fregante added the meta Related to Refined GitHub itself label Sep 22, 2025
@willdurand
Copy link
Contributor Author
willdurand commented Sep 23, 2025

Ha. Yes. Sorry about that. It is indeed browser_specific_settings.

@fregante fregante merged commit 928232b into refined-github:main Sep 23, 2025
12 of 13 checks passed
@fregante fregante changed the title Remove the add-on id in bss.gecko_android Meta: Remove gecko_android.id from manifest Sep 23, 2025
@willdurand willdurand deleted the patch-1 branch September 23, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

meta Related to Refined GitHub itself

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willdurand @fregante @jdreesen
0