unread-anywhere - Add button
#8638
Conversation
|
To me, that style looks like a broken button (or a missing icon). I'll disable the feature anyway (because I have too many unread notifications for it to be useful), so I don't care enough to open an issue about it. |
|
I don't plan on using this feature, because to me, keeping unread notifications unread is an important part of making sure I read them at the right time, and I have a mix of personal and professional notifications, so I never want to mix them. There was a suggestion on making it on alt+click that was set aside as "too hard to discover to be useful". What about changing the tooltip of the button to "You have unread notifications. Use alt+click to open them all" That said, I've disabled the feature. I think it's the first time I had to do that, and I'm perfectly fine doing that, but I wanted to offer some feedback so that there's a chance to revisit design choices. But, again, I'm perfectly fine if nothing changes. |
|
Thanks for the feedback! Keep them coming. This is the reasoning:
This is the closest I could get:
Improvements are still possible, so I'm open to suggestions. For example:
|
there is ?! I never saw it ! (I'm seeing it now) |
|
heheh yes! For future reference, this is what I see after opening your notification: 
|
|
A suggestion: a dropdown in the style of the copilot button ? It means it takes 2 clicks, BUT they're much closer from one another than a confirm dialog Edit: an additional thought: it's fairly obvious what each button in the top bar does without needing the tooltip. (Assuming you remember that the circle with dot now means "issue", but that ship has sailed). That small button now really is something you need the tooltip to have an idea what it does. It sure means "something something notifications", but it's hard to guess. |
This violates the second rule: can't be too big. I think I'd need to go back to playing with the blue indicator, but without a blue center because it makes it too visually distracting 
I think there's no way to fulfill these two constraints at the same time:
This is basically the only option, but it still looks weird to have a "duplicate" notifications action so far away from the notifications. 
As you said, the "too many icons" ship has sailed. You will find out what it means by hovering it. |
|
See #8642 |
unread-anywhere- Add button #8619The notification buttons is a rather vital part of GitHub so changes here need to be careful.
I thought about using a larger blue bubble but that is both visually distracting and not really clickable (it's
::before, which you can't detect in aclickevent)This style was one of the ones initially suggested.
Also I left it visible even if there are no notifications, because GitHub's UI is not necessarily up to date (#1426)
Screenshot