8000 `pr-jump-to-first-non-viewed-file` - Fix click conflicts by fregante · Pull Request #8636 · refined-github/refined-github · GitHub
[go: up one dir, main page]
Skip to content

pr-jump-to-first-non-viewed-file - Fix click conflicts #8636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 1 commit into from
Aug 23, 2025
Merged

pr-jump-to-first-non-viewed-file - Fix click conflicts #8636

fregante merged 1 commit into from
Aug 23, 2025

Conversation

@fregante
Copy link
Member
@fregante fregante commented Aug 23, 2025 •
edited
Loading

@fregante fregante added the bug label Aug 23, 2025
fregante
fregante commented Aug 23, 2025
View reviewed changes
source/features/pr-jump-to-first-non-viewed-file.tsx

const selectors = [
'.diffbar-item progress-bar', // TODO: Old PR Files view, drop in 2026
'section[class*="PullRequestFilesToolbar-module"] > div:last-child',
Copy link
Member Author
@fregante fregante Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was selecting the whole chunk of buttons including "Submit review"

@fregante fregante requested a review from kovsu August 23, 2025 07:01
@fregante fregante marked this pull request as ready for review August 23, 2025 07:01
@fregante fregante merged commit 1dd8e3e into main Aug 23, 2025
15 checks passed
@fregante fregante deleted the viewed-file-progress branch October 13, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kovsu kovsu Awaiting requested review from kovsu

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clicking "filter files" on the new GitHub PR UI focuses the first file (pr-jump-to-first-non-viewed-file)

2 participants

@fregante
0