8000 `small-user-avatars` - Adjust spacing by Katsute · Pull Request #7004 · refined-github/refined-github · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@Katsute
Copy link
Contributor
@Katsute Katsute commented Oct 29, 2023

Fixes #7002

Adds left margin to user avatars to better match word spacing

Test URLs

Hello world. @Katsute
Hello world. Omniscience
@Katsute
Ordinary

Screenshot

image

image

@ItsHarper
Copy link
ItsHarper commented Oct 31, 2023

While I much prefer this to the status quo, now there's a little too much margin to my eyes (please forgive the pickiness). In particular, I think the fact that it's still not aligned when a paragraph starts with a mention doesn't look good.

Screenshot 2023-10-31 143308

Screenshot 2023-10-31 143104

@Katsute
Copy link
Contributor Author
Katsute commented Oct 31, 2023

image

@fregante
Copy link
Member
fregante commented Nov 1, 2023

Thanks for looking into this! The issue is due to the image's border not using border but box-shadow, so it doesn't expand the img's box. The border here is 1px so we should match that, it seems that when comparing it to the letter O it aligns decently, while 2px seems too much (especially on a new line)

2px

Screenshot 13

1px

Screenshot 12

@fregante fregante added the bug label Nov 1, 2023
@fregante fregante changed the title small-user-avatars - Add spacing before mention avatars small-user-avatars - Adjust spacing Nov 1, 2023
.rgh-small-user-avatars {
margin-left: -3px;
margin-right: 2px !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested CSS like it's 2023😎

@fregante fregante merged commit 77f0031 into refined-github:main Nov 1, 2023
@Katsute Katsute deleted the small-user-avatars-ms branch November 1, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

small-user-avatars needs more spacing before a user mention

3 participants

0