10000 Skip excluded tag in container by Myks92 · Pull Request #710 · rectorphp/rector-symfony · GitHub
[go: up one dir, main page]
Skip to content

Skip excluded tag in container #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Skip excluded tag in container #710

merged 1 commit into from
Mar 28, 2025

Conversation

Myks92
Copy link
Contributor
@Myks92 Myks92 commented Mar 24, 2025

Since symfony/symfony#46279, Symfony Dependency Injection add the "container.exclude" to auto-discovered classes that are excluded by manual config. I also have made a pull request symfony/symfony#50452 which solved the problem with displaying services in the console. But Rector does not consider this in any way. This PR solves this problem and also closes the issue #709

@Myks92 Myks92 mentioned this pull request Mar 24, 2025
Closed
@TomasVotruba
Copy link
Member
TomasVotruba commented Mar 28, 2025 •
edited
Loading

Looks good, thank you for addition 🤗

@TomasVotruba TomasVotruba merged commit 49e65e6 into rectorphp:main Mar 28, 2025
5 checks passed
@Myks92 Myks92 deleted the skip-excluded-tag branch March 28, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Myks92 @TomasVotruba
0