8000 [Php82] Handle implicit public readonly on ReadOnlyClassRector by samsonasik · Pull Request #6919 · rectorphp/rector-src · GitHub
[go: up one dir, main page]
Skip to content

[Php82] Handle implicit public readonly on ReadOnlyClassRector #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

[Php82] Handle implicit public readonly on ReadOnlyClassRector #6919

merged 2 commits into from
May 22, 2025

Conversation

samsonasik
Copy link
Member

Continue of PR:

this handle on property, that cause crash:

Parse error: syntax error, unexpected identifier "string", expecting "function"

Ref https://3v4l.org/JTelr
Ref https://getrector.com/demo/61b8bb24-c87f-4e92-97f2-b326d3051e55

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit e02e813 into main May 22, 2025
45 checks passed
@samsonasik samsonasik deleted the implicit-prop branch May 22, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik
0