8000 [Alternative] Add EnumCaseToPascalCaseRector with use of DynamicSourceLocatorProvider by samsonasik · Pull Request #6899 · rectorphp/rector-src · GitHub
[go: up one dir, main page]
Skip to content

[Alternative] Add EnumCaseToPascalCaseRector with use of DynamicSourceLocatorProvider #6899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Alternative] Add EnumCaseToPascalCaseRector with use of DynamicSourceLocatorProvider #6899

wants to merge 10 commits into from

Conversation

samsonasik
Copy link
Member
@samsonasik samsonasik commented May 12, 2025 •
edited
Loading

@marcelthole here I cherry-picked your commits from PR:

as an alternative PR, this utilize DynamicSourceLocatorProvider which verify target is on the Reflector which use of paths defined in configuration.

The StatusEnum needs to be moved to Source so it marked as "outside" Fixture so be skipped from change.
This on unit test, I add includeFixtureDirectoryAsSource flag so defined PHP classes in Fixture directory can be load when set.

Closes #6890

@samsonasik samsonasik mentioned this pull request May 12, 2025
Closed
@samsonasik
Copy link
Member Author

@marcelthole @TomasVotruba All checks have passed 🎉 🎉 🎉 I think it is ready ;)

@samsonasik samsonasik force-pushed the alternative-pascal-case-enum-names branch from 22495d0 to 10ce326 Compare May 14, 2025 22:28
@samsonasik
Copy link
Member Author

Rebased and cleaned up use of BetterReflection classes usage 10ce326 👍

@samsonasik samsonasik force-pushed the alternative-pascal-case-enum-names branch from 10ce326 to 97995f7 Compare May 18, 2025 10:35
@samsonasik
Copy link
Member Author

Rebased and cleaned up unnecessary manual reset as already in setUp() as DynamicSourceLocatorProvider already on ResetableInterface 97995f7

@samsonasik samsonasik mentioned this pull request May 20, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @marcelthole
0