UseIdenticalOverEqualWithSameTypeRector should not trust phpdoc (#6880)

staabm · web-flow · commit fdbcc40e816c · 2025-05-05T19:16:31.000+07:00
* UseIdenticalOverEqualWithSameTypeRector should not trust phpdoc

* fix

* better fix

* Update skip_phpdoc_shape.php.inc
diff --git a/rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_phpdoc_shape.php.inc b/rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_phpdoc_shape.php.inc
@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+final class SkipPhpdocArrayshape
+{
+    /**
+     * @return array{'sql': string, 'files': array<string>}
+     */
+    public function getContent(): array
+    {
+    }
+
+    public function import()
+    {
+        $content = $this->getContent();
+
+        if (! isset($content['sql']) || $content['sql'] == '') {
+        }
+    }
+}
diff --git a/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php b/rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php
@@ -5,6 +5,7 @@
 namespace Rector\CodeQuality\Rector\Equal;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\BinaryOp\Equal;
 use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\BinaryOp\NotEqual;
@@ -64,6 +65,10 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        if ($node->left instanceof ArrayDimFetch || $node->right instanceof ArrayDimFetch) {
+            return null;
+        }
+
         $leftStaticType = $this->nodeTypeResolver->getNativeType($node->left);
         $rightStaticType = $this->nodeTypeResolver->getNativeType($node->right);
 
