[TypeDeclaration] Skip __destruct() from add return type based on parent on AddReturnTypeDeclarationBasedOnParentClassMethodRector (#6883)

samsonasik · web-flow · commit c6df7f5f25ba · 2025-05-05T19:13:48.000+07:00
* [TypeDeclaration] Skip __destruct() from add return type based on parent on AddReturnTypeDeclarationBasedOnParentClassMethodRector

* Fix
diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationBasedOnParentClassMethodRector/Fixture/skip_destruct.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationBasedOnParentClassMethodRector/Fixture/skip_destruct.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationBasedOnParentClassMethodRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationBasedOnParentClassMethodRector\Source\SomeClassWithoutReturnType;
+
+class SkipDestruct extends SomeClassWithoutReturnType
+{
+    public function __destruct()
+    {
+    }
+}
diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationBasedOnParentClassMethodRector/Source/SomeClassWithoutReturnType.php b/rules-tests/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationBasedOnParentClassMethodRector/Source/SomeClassWithoutReturnType.php
@@ -10,4 +10,8 @@ public function run()
     {
       return 5;
     }
+
+    public function __destruct()
+    {
+    }
 }
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationBasedOnParentClassMethodRector.php b/rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeDeclarationBasedOnParentClassMethodRector.php
@@ -93,7 +93,7 @@ public function refactor(Node $node): ?Node
         $hasChanged = false;
 
         foreach ($node->getMethods() as $classMethod) {
-            if ($this->isName($classMethod, MethodName::CONSTRUCT)) {
+            if ($this->isNames($classMethod, [MethodName::CONSTRUCT, MethodName::DESCTRUCT])) {
                 continue;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,8 @@ public funct 8000 ion run()`
`10`	`10`	`{`
`11`	`11`	`return 5;`
`12`	`12`	`}`
	`13`	`+`
	`14`	`+ public function __destruct()`
	`15`	`+ {`
	`16`	`+ }`
`13`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public function refactor(Node $node): ?Node`
`93`	`93`	`$hasChanged = false;`
`94`	`94`
`95`	`95`	`foreach ($node->getMethods() as $classMethod) {`
`96`		`- if ($this->isName($classMethod, MethodName::CONSTRUCT)) {`
	`96`	`+ if ($this->isNames($classMethod, [MethodName::CONSTRUCT, MethodName::DESCTRUCT])) {`
`97`	`97`	`continue;`
`98`	`98`	`}`
`99`	`99`