Add failing test fixture for StaticDataProviderClassMethodRector with ignored abstract parent test case
#160
Conversation
# Failing Test for StaticDataProviderClassMethodRector Based on https://getrector.com/demo/9372e294-4277-4bb9-abeb-34764c0b053c
StaticDataProviderClassMethodRector with ignored abstract parent test case
|
This is identical to already fixed #156 How is it different? |
|
I told rector to skip the abstract class, which cannot be reflected in the failing test case |
|
I see. It only works for explicit paths, no magic :) Also, the |
|
Btw, what is reason to ignore any files here? The upgrade must handle all files. |
|
In Symfony all abstract cases in /Test/ namespace are under BC promise and can be used in username. All abstract testcases in /Tests/ namespace are considered internal and are only used for our codebase, which we can change but the ones in /Test/ need to have an upgrade path including deprecations we need to find manually. But ofc our own tests in /Test/ are using the abstract testcases from /Test/ I hope I make it clear 😃 thanks for your time |
|
I see :) That's super specific use case that would be only useful for Symfony core project. I think for that would be best just to fork Rector rule to custom one and apply this logic there. |
Failing Test for StaticDataProviderClassMethodRector
Based on https://getrector.com/demo/9372e294-4277-4bb9-abeb-34764c0b053c
Explanation
Because the parent abstract class is skipped in rector config, their child classes should be ignored for this rector as well. Check the demo link please, thanks.
This test should be failing ❗
Spotted in
staticdata providers usingrector/rectorsymfony/symfony#48668