8000 Clean-up Wax Poetic challenge solution by somacdivad · Pull Request #18 · realpython/python-basics-exercises · GitHub
[go: up one dir, main page]
Skip to content

Clean-up Wax Poetic challenge solution #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2020
Merged

Clean-up Wax Poetic challenge solution #18

merged 2 commits into from
Jul 20, 2020

Conversation

somacdivad
Copy link
Contributor
@somacdivad somacdivad commented Feb 18, 2020 •
edited
Loading

The Wax Poetic challenge solution needed a bit of a style clean-up.

Changes:

  • Used import random instead of from random import choice and replaced all instances of choice() function with random.choice(). This is better practice and aligns better with the challenge instructions
  • Changed comments to use PEP 8 formatting

DO NOT MERGE until next book update that includes commit https://github.com/realpython/book1/commit/1362f06b1ffd75ddcc647e5a687f69896f97a859.

@somacdivad somacdivad added the merge on next update Do not merge this PR until the next book update has been released. label Feb 18, 2020
@somacdivad somacdivad merged commit f465001 into master Jul 20, 2020
@somacdivad somacdivad deleted the clean-wax-poetic-challenge branch July 20, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge on next update Do not merge this PR until the next book update has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@somacdivad
0