8000 Move results path cleanup to pytest_unconfigure by dmtucker · Pull Request #181 · realpython/pytest-mypy · GitHub
[go: up one dir, main page]
Skip to content

Move results path cleanup to pytest_unconfigure #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Move results path cleanup to pytest_unconfigure #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c55a9ea
Replace MypyReportingPlugin with MypyControllerPlugin
dmtucker Sep 6, 2024
97e8f41
Move results path cleanup to pytest_unconfigure
dmtucker Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/pytest_mypy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def pytest_configure(config: pytest.Config) -> None:
"""
xdist_worker = _xdist_worker(config)
if not xdist_worker:
config.pluginmanager.register(MypyReportingPlugin())
config.pluginmanager.register(MypyControllerPlugin())

# Get the path to a temporary file and delete it.
# The first MypyItem to run will see the file does not exist,
Expand Down Expand Up @@ -372,15 +372,15 @@ class MypyWarning(pytest.PytestWarning):
"""A non-failure message regarding the mypy run."""


class MypyReportingPlugin:
"""A Pytest plugin that reports mypy results."""
class MypyControllerPlugin:
"""A plugin that is not registered on xdist worker processes."""

def pytest_terminal_summary(
self,
terminalreporter: TerminalReporter,
config: pytest.Config,
) -> None:
"""Report stderr and unrecognized lines from stdout."""
"""Report mypy results."""
mypy_results_path = config.stash[stash_key["config"]].mypy_results_path
try:
with open(mypy_results_path, mode="r") as results_f:
Expand All @@ -397,4 +397,11 @@ def pytest_terminal_summary(
terminalreporter.write_line(results.unmatched_stdout, **color)
if results.stderr:
terminalreporter.write_line(results.stderr, yellow=True)
mypy_results_path.unlink()

def pytest_unconfigure(self, config: pytest.Config) -> None:
"""Clean up the mypy results path."""
try:
config.stash[stash_key["config"]].mypy_results_path.unlink()
except FileNotFoundError: # compat python < 3.8 (missing_ok=True)
# No MypyItems executed.
return
Loading
0