8000 junit: add testsuite name and failure line metadata by theamodhshetty · Pull Request #6512 · realm/SwiftLint · GitHub
[go: up one dir, main page]
Skip to content

junit: add testsuite name and failure line metadata#6512

Open
theamodhshetty wants to merge 2 commits intorealm:mainfrom
theamodhshetty:codex/junit-testsuite-name
Open

junit: add testsuite name and failure line metadata#6512
theamodhshetty wants to merge 2 commits intorealm:mainfrom
theamodhshetty:codex/junit-testsuite-name

Conversation

@theamodhshetty
Copy link
Contributor
@theamodhshetty theamodhshetty commented Feb 27, 2026

Summary

Follow-up to #6161 to improve JUnit XML compatibility for CI parsers.

What changed

  • Added name="SwiftLint" to the <testsuite> element in JUnitReporter.
  • Added line="..." attribute to each <failure> element.
  • Updated canned JUnit reporter fixture to match the new output.
  • Added a changelog entry in Main > Enhancements.

Why

Some JUnit consumers rely on suite naming and explicit line metadata for better ingestion/rendering.
SwiftLint already reports counts; this adds metadata without changing violation semantics.

Validation

  • swift test --filter ReporterTests/testJunitReporter
  • swift test --filter ReporterTests

Checklist

  • Reporter output updated
  • Fixture/test updated
  • Changelog entry added

@theamodhshetty theamodhshetty mentioned this pull request Feb 27, 2026
Open
2 tasks
@SwiftLintBot
Copy link
SwiftLintBot commented Feb 27, 2026 •
edited
Loading
19 Messages
📖 Building this branch resulted in the same binary size as when built on main.
📖 Linting Aerial with this PR took 0.82 s vs 0.82 s on main (0% slower).
📖 Linting Alamofire with this PR took 1.05 s vs 1.03 s on main (1% slower).
📖 Linting Brave with this PR took 7.16 s vs 7.15 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 25.69 s vs 25.66 s on main (0% slower).
📖 Linting Firefox with this PR took 11.8 s vs 11.77 s on main (0% slower).
📖 Linting Kickstarter with this PR took 8.03 s vs 8.03 s on main (0% slower).
📖 Linting Moya with this PR took 0.48 s vs 0.46 s on main (4% slower).
📖 Linting NetNewsWire with this PR took 2.43 s vs 2.45 s on main (0% faster).
📖 Linting Nimble with this PR took 0.69 s vs 0.69 s on main (0% slower).
📖 Linting PocketCasts with this PR took 7.62 s vs 7.66 s on main (0% faster).
📖 Linting Quick with this PR took 0.46 s vs 0.45 s on main (2% slower).
📖 Linting Realm with this PR took 2.95 s vs 2.97 s on main (0% faster).
📖 Linting Sourcery with this PR took 1.86 s vs 1.88 s on main (1% faster).
📖 Linting Swift with this PR took 4.6 s vs 4.62 s on main (0% faster).
📖 Linting SwiftLintPerformanceTests with this PR took 0.33 s vs 0.33 s on main (0% slower).
📖 Linting VLC with this PR took 1.15 s vs 1.15 s on main (0% slower).
📖 Linting Wire with this PR took 18.51 s vs 18.44 s on main (0% slower).
📖 Linting WordPress with this PR took 12.54 s vs 12.49 s on main (0% slower).

Generated by 🚫 Danger

SimplyDanny
SimplyDanny reviewed Feb 27, 2026
View reviewed changes
Copy link
Collaborator
@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two remarks ...

@SimplyDanny SimplyDanny enabled auto-merge (squash) February 28, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimplyDanny SimplyDanny SimplyDanny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theamodhshetty @SwiftLintBot @SimplyDanny
0