8000 Update PHPStan by ondrejmirtes · Pull Request #251 · reactphp/promise · GitHub
[go: up one dir, main page]
Skip to content

Update PHPStan #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Update PHPStan #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"php": ">=7.1.0"
},
"require-dev": {
"phpstan/phpstan": "1.10.20 || 1.4.10",
"phpstan/phpstan": "1.10.34 || 1.4.10",
"phpunit/phpunit": "^9.5 || ^7.5"
},
"autoload": {
Expand Down
18 changes: 9 additions & 9 deletions tests/types/reject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
use function React\Promise\reject;
use function React\Promise\resolve;

assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException()));
assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->then(null, null));
// assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->then(function (): int {
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException()));
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->then(null, null));
// assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->then(function (): int {
// return 42;
// }));
assertType('React\Promise\PromiseInterface<int>', reject(new RuntimeException())->then(null, function (): int {
Expand All @@ -32,11 +32,11 @@
return resolve(42);
}));

assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->finally(function (): void { }));
assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->finally(function (): never {
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->finally(function (): void { }));
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->finally(function (): never {
throw new \UnexpectedValueException();
}));
assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->finally(function (): PromiseInterface {
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->finally(function (): PromiseInterface {
return reject(new \UnexpectedValueException());
}));

Expand All @@ -50,10 +50,10 @@
return resolve(42);
}));

assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->always(function (): void { }));
assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->always(function (): never {
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->always(function (): void { }));
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->always(function (): never {
throw new \UnexpectedValueException();
}));
assertType('React\Promise\PromiseInterface<*NEVER*>', reject(new RuntimeException())->always(function (): PromiseInterface {
assertType('React\Promise\PromiseInterface<never>', reject(new RuntimeException())->always(function (): PromiseInterface {
return reject(new \UnexpectedValueException());
}));
10 changes: 5 additions & 5 deletions tests/types/resolve.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function stringOrIntPromise(): PromiseInterface {
assertType('React\Promise\PromiseInterface<int>', resolve(true)->then(function (bool $value): PromiseInterface {
return resolve(42);
}));
assertType('React\Promise\PromiseInterface<*NEVER*>', resolve(true)->then(function (bool $value): never {
assertType('React\Promise\PromiseInterface<never>', resolve(true)->then(function (bool $value): never {
throw new \RuntimeException();
}));
assertType('React\Promise\PromiseInterface<bool|int>', resolve(true)->then(null, function (\Throwable $e): int {
Expand All @@ -61,10 +61,10 @@ function stringOrIntPromise(): PromiseInterface {
}));

assertType('React\Promise\PromiseInterface<bool>', resolve(true)->finally(function (): void { }));
// assertType('React\Promise\PromiseInterface<*NEVER*>', resolve(true)->finally(function (): never {
// assertType('React\Promise\PromiseInterface<never>', resolve(true)->finally(function (): never {
// throw new \RuntimeException();
// }));
// assertType('React\Promise\PromiseInterface<*NEVER*>', resolve(true)->finally(function (): PromiseInterface {
// assertType('React\Promise\PromiseInterface<never>', resolve(true)->finally(function (): PromiseInterface {
// return reject(new \RuntimeException());
// }));

Expand All @@ -79,9 +79,9 @@ function stringOrIntPromise(): PromiseInterface {
}));

assertType('React\Promise\PromiseInterface<bool>', resolve(true)->always(function (): void { }));
// assertType('React\Promise\PromiseInterface<*NEVER*>', resolve(true)->always(function (): never {
// assertType('React\Promise\PromiseInterface<never>', resolve(true)->always(function (): never {
// throw new \RuntimeException();
// }));
// assertType('React\Promise\PromiseInterface<*NEVER*>', resolve(true)->always(function (): PromiseInterface {
// assertType('React\Promise\PromiseInterface<never>', resolve(true)->always(function (): PromiseInterface {
// return reject(new \RuntimeException());
// }));
0