Update PHPUnit configuration schema for PHPUnit 9.3 and minor clean up #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
clue
approved these changes
Aug 18, 2020
cdosoftei
added a commit
to singlecomm/promise
that referenced
this pull request
Aug 18, 2020
WyriHaximus
approved these changes
Aug 18, 2020
jsor
approved these changes
Aug 19, 2020
cdosoftei
added a commit
to singlecomm/promise
that referenced
this pull request
Aug 20, 2020
Adjustments for 7.1, support for union types, test suite updates Reinstated previous PHPUnit XML config (dupe of reactphp#177) Code tweaks and test adjustments Test tweaks _checkType tests cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 9.3 released a new schema for the
phpunit.xmlconfiguration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use thephpunit.xml.legacyconfiguration file, because the new format is unknown for them.For further details concerning this pull request look into graphp/graphviz #46.
This pull request builds on top of reactphp/promise #175.
Together with the changes from reactphp/promise #176 by @cdosoftei it's possible to run this code with PHP 8 🎉