8000 Test PHP 7.4 on Travis by clue · Pull Request #162 · reactphp/promise · GitHub
[go: up one dir, main page]
Skip to content

Test PHP 7.4 on Travis #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2020
Merged

Test PHP 7.4 on Travis #162

merged 2 commits into from
Mar 5, 2020

Conversation

clue
Copy link
Member
@clue clue commented Mar 4, 2020 •
edited
Loading

Builds on top of #157, thanks @WyriHaximus for the original version and helping tracking this down with @CharlotteDunois. This changeset builds on top of this, but instead of skipping affected tests will make sure tests pass by clearing any garbage references twice before running any of the affected assertions.

I still wonder if this could potentially be an upstream bug in ext-xdebug or PHP itself, but I don't see any guarantees that gc_collect_cycles() collects all cycles, so perhaps we were just lucky in previous versions. I consider this minimal changeset to be good enough until we find a better solution in the future :shipit:

@clue clue added this to the v3.0.0 milestone Mar 4, 2020
@clue clue requested review from WyriHaximus and jsor March 4, 2020 10:15
@clue clue mentioned this pull request Mar 4, 2020
Merged
@clue
Clear garbage references twice before starting tests
6ee24c2 
Clear twice to avoid leftovers in PHP 7.4 with ext-xdebug and code
coverage turned on (`vendor/bin/phpunit --coverage-text`).
This was referenced Mar 4, 2020
Closed
Merged
Merged
Merged
@jsor jsor merged commit e400476 into reactphp:master Mar 5, 2020
@clue clue deleted the php7.4 branch March 5, 2020 15:03
@WyriHaximus WyriHaximus mentioned this pull request Apr 26, 2020
Closed
@SimonFrings SimonFrings mentioned this pull request May 6, 2020
Merged
This was referenced Jul 10, 2023
Merged
Merged
@clue clue mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus
0