10000 Update SocketClient to v0.6 by clue · Pull Request #74 · reactphp/http-client · GitHub
[go: up one dir, main page]
Skip to content

Update SocketClient to v0.6 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2017
Merged

Update SocketClient to v0.6 #74

merged 1 commit into from
Mar 20, 2017

Conversation

clue
Copy link
Member
@clue clue commented Mar 9, 2017

No description provided.

@jsor
Copy link
Member 8000
jsor commented Mar 9, 2017

I've filed #75 to fix the tests.

@WyriHaximus
Copy link
Member

@jsor merged #75, could you rebase? :shipit:

@jsor
Copy link
Member
jsor commented Mar 9, 2017

@WyriHaximus This is @clue's PR ;)

@clue
Copy link
Member Author
clue commented Mar 10, 2017

Rebased on current master now that #75 is in :shipit:

@WyriHaximus
Copy link
Member
WyriHaximus commented Mar 10, 2017 •
edited
Loading

@jsor oops 🤐

LGTM, but do we want to release this in v0.4.17 or make a larger release v0.5.0 with breaking changes?

@clue
Copy link
Member Author
clue commented Mar 10, 2017

Afaict while this does limit which what dependency versions this is compatible, it does not cause a BC break. I know we've had this discussion before, so I'll leave this up to you 👍

I'm currently looking into providing proper streaming support for v0.5.0, so we may as well delay this.

@WyriHaximus
Copy link
Member

I'm currently looking into providing proper streaming support for v0.5.0, so we may as well delay this

Sounds like a good plan to me 👍

@clue clue added this to the v0.5.0 milestone Mar 20, 2017
@clue clue merged commit 985f8a0 into reactphp:master Mar 20, 2017
@clue clue deleted the socket-client branch March 20, 2017 10:06
@clue clue mentioned this pull request Apr 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
easy pick maintenance new feature
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus
0