E5ED StreamSelectLoop: Fix erroneous zero-time sleep (2) by ivkalita · Pull Request #93 · reactphp/event-loop · GitHub
[go: up one dir, main page]
Skip to content

StreamSelectLoop: Fix erroneous zero-time sleep (2) #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsor merged 2 commits into from
Apr 4, 2017
Merged

StreamSelectLoop: Fix erroneous zero-time sleep (2) #93

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdc6191
Add StreamSelectLoop test for timer with small interval.
ivkalita Apr 3, 2017
09cd0bc
Add StreamSelectLoop timeout rounding.
ivkalita Apr 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add StreamSelectLoop timeout rounding.
  • Loading branch information
@ivkalita
ivkalita committed Apr 3, 2017
commit 09cd0bcb4038dea3e84283984a011fc2c32285f0
6 changes: 5 additions & 1 deletion src/StreamSelectLoop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,11 @@ public function run()
if ($timeout < 0) {
$timeout = 0;
} else {
$timeout *= self::MICROSECONDS_PER_SECOND;
/*
* round() needed to correct float error:
* https://github.com/reactphp/event-loop/issues/48
*/
$timeout = round($timeout * self::MICROSECONDS_PER_SECOND);
}

// The only possible event is stream activity, so wait forever ...
Expand Down
0