8000 Restructure and improve README by jsor · Pull Request #90 · reactphp/event-loop · GitHub
[go: up one dir, main page]

Skip to content

Restructure and improve README #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2017
Merged

Conversation

jsor
Copy link
Member
@jsor jsor commented Mar 27, 2017
  • Separate into sections and add a TOC at the beginning
  • Add new sections for Install, Tests and License
  • Add paragraph to Usage emphasizing on recommended program structuring using a single loop instance

* Separate into sections and add a TOC at the beginning
* Add new sections for Install, Tests and License
* Add paragraph to Usage emphasizing on recommended program structuring using a single loop instance
Copy link
Member
@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much like the new structure 👍

README.md Outdated
In order for async based libraries to be interoperable, they need to use the
same event loop. This component provides a common `LoopInterface` that any
library can target. This allows them to be used in the same loop, with one
single `run()` call that is controlled by the user.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this paragraph stay at the top, right below the tag line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i was unsure either and moved the paragraph up and down several times while working on the patch 😃

In the end i decided to put it under Usage because i thought it fits there and might be easily overlooked at the beginning. My guess is, that users skip the "promotion" parts at just jump straight to the usage section.

But i'd be fine with both locations. @WyriHaximus, @cboden?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial paragraph should try to sell this idea to newcomers and explain the WHY. This is also what will be shown as an "abstract" in many applications, e.g. the first paragraph will be shown in mobile view, while the rest will be hidden by default.

IMHO the why is the most important part of the documentation, but we may as well duplicate this below if this makes sense. Otherwise, we may also fine-tune this later on 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the paragraph back to the top and replaced it here with a short introduction.

@jsor jsor requested a review from WyriHaximus March 27, 2017 12:44
@jsor jsor merged commit 9504651 into reactphp:0.4 Mar 27, 2017
@jsor jsor added this to the v0.4.3 milestone Mar 27, 2017
@jsor jsor deleted the 0.4-readme-improvements branch March 27, 2017 13:34
@jsor jsor mentioned this pull request Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0