Add tests for double watchers to be ignored #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Mar 25, 2017
|
@clue Not sure whether it should be an exception or just call all callbacks. |
WyriHaximus
approved these changes
Mar 25, 2017
|
@kelunik Both would be valid options IMHO. Do you feel like filing an issue or preparing a PR so we can discuss this and its implications? 👍 |
|
Done via #87. |
jsor
approved these changes
Mar 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the current behavior. I think the behavior should be changed to throw an exception instead of silently ignoring those callables or just call both callables.