Travis improvements #74
Conversation
| @@ -5,9 +5,23 @@ php: | |||
| - 5.5 | |||
| - 5.6 | |||
| - 7.0 | |||
| - 7.1 | |||
There was a problem hiding this comment.
Maybe something we can add in another PR since it would probably introduce allow_failures also.
There was a problem hiding this comment.
Yes, allow_failures is a good idea for nightly.
| @@ -5,9 +5,23 @@ php: | |||
| - 5.5 | |||
| - 5.6 | |||
| - 7.0 | |||
| - 7.1 | |||
There was a problem hiding this comment.
Not sure if we have a consensus here yet. Do we really want to add every single future version for all components?
Other than that, LGTM 👍
There was a problem hiding this comment.
I'd say yes. Since this is a core component, i think we should run the tests against as much versions as possible.
But i agree that this change should have probably been introduced in another PR.
There was a problem hiding this comment.
Not sure if we have a consensus here yet. Do we really want to add every single future version for all components?
Have re-read this now: I think it makes sense for this component. If this makes sense for all components is arguable.
There was a problem hiding this comment.
Personally I would prefer testing all versions we support to ensure we don't run into weird issues. We also might want to use the new cron feature to schedule builds, but that only makes sense with nightly tbh.
.travis.yml
Outdated
|
|
||
| cache: | ||
| directories: | ||
| - $HOME/.composer/cache |
There was a problem hiding this comment.
Changing this to $HOME/.composer/cache/files will ensure we only cache package files and not the meta files.
|
For the reference: Updated the milestone to "v0.5.0" because this actually landed in the master branch instead of the "0.4" release branch (because it's been merged after #72). |
This contains all changes from reactphp#74 squashed into a single commit: * Remove deprecated --dev option from composer install * Remove --prefer-source from composer install * Move composer install to .travis.yml * Enable container based infrastructure on travis * Enable travis cache * Add PHP 7.1 to test matrix * Adjust composer cache directory to only cache package files
Travis improvements (backported from #74)
Main changes are:
Enabled running tests on travis' container based infrastructure
This solves that tests can now be run for forks which default to the container based infrastructure when created after 2015.
Refs:
composer install--devoption--prefer-sourcenot longer required to prevent rate limit issues, see Drupal can't use composer install because it requires a Github Auth token on installation composer/composer#4884 (comment)Run tests on PHP 7.1