[WIP] moved signal handling tests to AbstractLoopTest #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not merge yet, this currently fails on various combinations of php versions, I'd like to fix it after reactphp#45 is merged to have tests run against all systems.
|
Ping @cebe, what's the status here? |
|
good question! I do not even remember that I did this :) |
|
Sorry, not going to happen within the next 1-2month. but I might eventually come back to this. |
|
I'll assume this is resolved via #104 and will close this for now, please feel free to report back otherwise 👍 |
|
seems to be fine. If its not, the changes are conflicting anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not merge yet, this currently fails on various combinations of php versions on my machine, created the PR to see how it works on travis.
I'd like to fix it after #45 is merged to have tests
run against all systems.