8000 Properly clean up event watchers for ext-event and ext-libev by clue · Pull Request #149 · reactphp/event-loop · GitHub
[go: up one dir, main page]
Skip to content

Properly clean up event watchers for ext-event and ext-libev #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Properly clean up event watchers for ext-event and ext-libev #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000 Diff view
Diff view
Properly clean up event watchers for ext-event and ext-libev
  • Loading branch information
@clue
clue committed Feb 6, 2018
commit 0f8c6b415d10a6c993717aff760c8407fec8dd17
8000 2 changes: 1 addition & 1 deletion src/ExtEventLoop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function ($signal) {
},
function ($signal) {
if ($this->signals->count($signal) === 0) {
$this->signalEvents[$signal]->del();
$this->signalEvents[$signal]->free();
unset($this->signalEvents[$signal]);
}
}
Expand Down
3 changes: 3 additions & 0 deletions src/ExtLibevLoop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up 8CC4 @@ -55,6 +55,7 @@ function ($signal) {
},
function ($signal) {
if ($this->signals->count($signal) === 0) {
$this->signalEvents[$signal]->stop();
$this->loop->remove($this->signalEvents[$signal]);
unset($this->signalEvents[$signal]);
}
Expand Down Expand Up @@ -100,6 +101,7 @@ public function removeReadStream($stream)

if (isset($this->readEvents[$key])) {
$this->readEvents[$key]->stop();
$this->loop->remove($this->readEvents[$key]);
unset($this->readEvents[$key]);
}
}
Expand All @@ -110,6 +112,7 @@ public function removeWriteStream($stream)

if (isset($this->writeEvents[$key])) {
$this->writeEvents[$key]->stop();
$this->loop->remove($this->writeEvents[$key]);
unset($this->writeEvents[$key]);
}
}
Expand Down
0