Fix test suite forward compatibility with upcoming EventLoop releases #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Dec 23, 2017
tests/Query/ExecutorTest.php
Outdated
| private function createTimerMock() | ||
| { | ||
| return $this->getMockBuilder( | ||
| 'React\EventLoop' . (interface_exists('React\EventLoop\TimerInterface') ? '' : '\Timer') . '\TimerInterface' |
There was a problem hiding this comment.
interface_exists('React\EventLoop\TimerInterface') ? 'React\EventLoop\TimerInterface' : 'React\EventLoop\Timer\TimerInterface' would be more readable IMO.
There was a problem hiding this comment.
Which is what I used before committing this, but it results in a rather long line :) Any suggestions?
There was a problem hiding this comment.
Anyway, updated to also match reactphp/promise-timer#31 👍
There was a problem hiding this comment.
I wouldn't care about a longer line if it's more readable and I don't have to think. Just format it with multiple lines if you care about that:
interface_exists('React\EventLoop\TimerInterface')
? 'React\EventLoop\TimerInterface'
: 'React\EventLoop\Timer\TimerInterface'Apart from that, just drop older PHP versions and use ::class ;-)
jsor
approved these changes
Dec 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs reactphp/event-loop#102 and reactphp/event-loop#138